Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-51418][SQL] Fix DataSource PARTITON TABLE w/ Hive type incompatible partition columns #50182

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Mar 6, 2025

What changes were proposed in this pull request?

25/03/06 08:25:17 WARN HiveExternalCatalog: Hive incompatible types found: timestamp_ntz. Persisting data source table `spark_catalog`.`default`.`c` into Hive metastore in Spark SQL specific format, which is NOT compatible with Hive.
org.apache.spark.sql.AnalysisException: org.apache.hadoop.hive.ql.metadata.HiveException: InvalidObjectException(message:Invalid partition column type: timestamp_ntz)

The partition columns are duplicated and stored both in the HMS column meta and the table properties. If they contain incompatible data types, the HMS Meta API will fail the process.

We can rely on the table properties to read/write

Why are the changes needed?

bugfix, otherwise, newly added spark data types are not able to be used as partition columns

Does this PR introduce any user-facing change?

Yes, More type cases are supported for partitioned datasouce tables stored in HMS

How was this patch tested?

new tests

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added the SQL label Mar 6, 2025
@yaooqinn yaooqinn marked this pull request as draft March 6, 2025 10:15
@yaooqinn yaooqinn marked this pull request as ready for review March 10, 2025 03:00
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs). Thank you, @yaooqinn .

@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun

The CI has already passed https://github.com/yaooqinn/spark/actions/runs/13718779026, but w/o being properly updated here.

Let's wait for the GA for the latest sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants